Update SDK versions for JavaSDK 1+2 and KCL #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendan-p-lynch
requested changes
Apr 15, 2024
| <kcl.version>2.5.2</kcl.version> | ||
| <awssdk.version>2.25.11</awssdk.version> | ||
| <aws-java-sdk.version>1.12.696</aws-java-sdk.version> | ||
| <kcl.version>2.5.8</kcl.version> |
There was a problem hiding this comment.
Still need the -SNAPSHOT version for testing. We should not be using this version as it will confuse local builds with public releases
| @@ -111,6 +111,31 @@ | |||
| <artifactId>auth</artifactId> | |||
| <version>${awssdk.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>software.amazon.awssdk</groupId> | |||
| <artifactId>http-auth-spi</artifactId> | |||
There was a problem hiding this comment.
Is there a reason these have to be added
There was a problem hiding this comment.
These were required on running, without which there was a class not found error when authenticating, with no code changes in my code from previous implementation.
I added the java sdk modules one-by-one until all class not found errors were resolved. This was with the default authentication chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updating the SDK and KCL versions to bring in latest changes - especially required for new regions and authentication methods.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.