Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on unimplemented methods #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fail on unimplemented methods #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d976c
Fail fast on unimplemented methods
Jul 15, 2015
ee1a059
Remove empty file
Jul 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed amazon_kclpy/jars/__init__.py
View file
Open in desktop
Empty file.
6 changes: 3 additions & 3 deletions amazon_kclpy/kcl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def initialize(self, shard_id):
:type shard_id: str
:param shard_id: The shard id that this processor is going to be working on.
'''
return
raise NotImplementedError

@abc.abstractmethod
def process_records(self, records, checkpointer):
Expand All @@ -192,7 +192,7 @@ def process_records(self, records, checkpointer):
:type checkpointer: amazon_kclpy.kcl.Checkpointer
:param checkpointer: A checkpointer which accepts a sequence number or no parameters.
'''
return
raise NotImplementedError

@abc.abstractmethod
def shutdown(self, checkpointer, reason):
Expand All @@ -210,7 +210,7 @@ def shutdown(self, checkpointer, reason):
shard so that this processor will be shutdown and new processor(s) will be created to for the child(ren) of
this shard.
'''
return
raise NotImplementedError

class MalformedAction(Exception):
'''
Expand Down