Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codebuild-ci.yml to not cancel ongoing integration test #21

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

baiyli
Copy link
Contributor

@baiyli baiyli commented Sep 10, 2024

Issue #, if available:

  • N/A

Description of changes:

  • Update codebuild-ci.yml to not cancel ongoing integration test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@adheshgarg adheshgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bhaoz bhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - one QQ: is it possible to add post-build steps to always try to clean up resources no matter tests passed or failed? This may be a great follow up

@baiyli
Copy link
Contributor Author

baiyli commented Sep 10, 2024

lgtm - one QQ: is it possible to add post-build steps to always try to clean up resources no matter tests passed or failed? This may be a great follow up

Good call. This may need more effort for making code changes on CDK side first. If we still see similar issues after this one get deployed, maybe we can work on this.

@baiyli baiyli merged commit 156662d into aws:main Sep 10, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants