-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable inference serving capabilities on sagemaker endpoint #536
base: main
Are you sure you want to change the base?
Conversation
9cee77b
to
bb132ea
Compare
build_artifacts/v2/v2.2/v2.2.0/dirs/etc/inference-server/server.py
Outdated
Show resolved
Hide resolved
build_artifacts/v2/v2.2/v2.2.0/dirs/etc/inference-server/server.py
Outdated
Show resolved
Hide resolved
build_artifacts/v2/v2.2/v2.2.0/dirs/etc/inference-server/server.py
Outdated
Show resolved
Hide resolved
build_artifacts/v2/v2.2/v2.2.0/dirs/etc/inference-server/server.py
Outdated
Show resolved
Hide resolved
build_artifacts/v2/v2.2/v2.2.0/dirs/etc/inference-server/server.py
Outdated
Show resolved
Hide resolved
build_artifacts/v2/v2.2/v2.2.0/dirs/etc/inference-server/server.py
Outdated
Show resolved
Hide resolved
build_artifacts/v2/v2.2/v2.2.0/dirs/etc/inference-server/tornado_server/sync_server.py
Outdated
Show resolved
Hide resolved
CODE_DIRECTORY = "SAGEMAKER_INFERENCE_CODE_DIRECTORY" | ||
CODE = "SAGEMAKER_INFERENCE_CODE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets discuss these inputs offline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will review these with Saurabh/PM since these will be customer facing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will schedule a meeting next week
Can you move your changes under "template" folder?
For any changes/additions in cpu/gpu.env.in file, please create an issue (example) so that we'll add them to the next image major/minor releases |
Moved the code to the v3 template folder since this code will be launching in the next major version release |
9865a75
to
4153ebb
Compare
template/v3/dirs/etc/sagemaker-inference-server/tornado_server/stream_handler.py
Outdated
Show resolved
Hide resolved
template/v3/dirs/etc/sagemaker-inference-server/tornado_server/async_handler.py
Outdated
Show resolved
Hide resolved
template/v3/dirs/etc/sagemaker-inference-server/tornado_server/async_handler.py
Show resolved
Hide resolved
template/v3/dirs/etc/sagemaker-inference-server/tornado_server/stream_handler.py
Show resolved
Hide resolved
template/v3/dirs/etc/sagemaker-inference-server/tornado_server/server.py
Outdated
Show resolved
Hide resolved
template/v3/dirs/etc/sagemaker-inference-server/tornado_server/server.py
Show resolved
Hide resolved
template/v3/dirs/etc/sagemaker-inference-server/tornado_server/server.py
Outdated
Show resolved
Hide resolved
template/v3/dirs/etc/sagemaker-inference-server/tornado_server/server.py
Show resolved
Hide resolved
4153ebb
to
f445e11
Compare
f445e11
to
141031a
Compare
LGTM! Could you add details about how this was tested though? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you have E2E integration tests ready for your entrypoint script. And before the automatic test is ready, can you share some manual test results and attach to this PR? For example, you may build an SMD images locally with your PR, and verify using it in sagemaker inference endpoint.
To build images with your changes, you can checkout release-3.0.0 branch and add your changes locally to folder https://github.com/aws/sagemaker-distribution/tree/release-3.0.0/build_artifacts/v3/v3.0/v3.0.0. Then, you can run the following commands to build your image:
conda env update --file environment.yml -n sagemaker-distribution
conda activate sagemaker-distribution
python ./src/main.py build --target-patch-version=3.0.0 --skip-tests
Description of changes:
Added source code to enable serving capabilities on SageMaker Endpoint.
Testing
Using a basic LCEL inference script:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.