refactor(telemetry): add functionality to @withTelemetryContext #5816
+231
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkomonen-amazon
force-pushed
the
addErrorContext
branch
2 times, most recently
from
7d2d5c1
to
b2cbc3f
Compare
The withTelemetryContext() decorator adds context to telemetry but not thrown errors. Solution: Adding this decorator to a method will add context to any thrown exceptions. This is helpful in telemetry as it will provide information about the caller. Signed-off-by: nkomonen-amazon <[email protected]>
Now the @withTelemetryContext decorator can have a method emit when called and will also add the `source` field automatically. By default it does not emit. Signed-off-by: nkomonen-amazon <[email protected]>
Signed-off-by: nkomonen-amazon <[email protected]>
nkomonen-amazon
force-pushed
the
addErrorContext
branch
from
b2cbc3f
to
654dc3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit for the specific change. But this has multiple improvements to the
@withTelemetryContextdecorator.The main change to note:
@withTelemetryContextdecorator to a method can wrap thrown errors with context about that function. This helps us to build some sort of stack trace in thereasonDescof our telemetry when errors are thrown.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.