Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): added mynah updated beta package for feature dev #5805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

32teeth
Copy link
Member

@32teeth 32teeth commented Oct 17, 2024

Problem

Solution

Update to mynah package to enable focus tab from notification


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@32teeth 32teeth requested a review from a team as a code owner October 17, 2024 16:40
Copy link

This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions.

@32teeth 32teeth changed the title feature: added mynah updated beta package for feature dev feat: added mynah updated beta package for feature dev Oct 17, 2024
@jpinkney-aws
Copy link
Contributor

Can you explain more about why we would move to a beta dependency?

@32teeth
Copy link
Member Author

32teeth commented Oct 17, 2024

Can you explain more about why we would move to a beta dependency?

@dogusata has implemented a feature to be able to select a tab by ID without passing an eventID in the NPM release

I've released a beta version which removes the eventId check from the selectTab method.
Please use version number as https://www.npmjs.com/package/@aws/mynah-ui/v/4.16.1-beta.1
When there is a new production release, it will contain this change. (Will be 4.16.1 or above)

@32teeth
Copy link
Member Author

32teeth commented Oct 17, 2024

I will amend the commit message this evening

@32teeth 32teeth force-pushed the andruseu/feature/update-mynah-package branch from a01f695 to 8410802 Compare October 17, 2024 21:39
@32teeth 32teeth force-pushed the andruseu/feature/update-mynah-package branch from 8410802 to fd5c7de Compare October 17, 2024 21:52
@32teeth 32teeth changed the title feat: added mynah updated beta package for feature dev feat(amazonq): added mynah updated beta package for feature dev Oct 17, 2024
@justinmk3
Copy link
Contributor

It looks like this may have a customer-facing impact that can be described in the changelog. The changelog is presented to users by VSCode and the marketplace. It is a "micro-blog" for advertising improvements to users. It is the primary way of communicating changes to customers.

  1. Review the changelog guidelines.
  2. Add a new changelog entry: npm run newChange -w packages/amazonq or npm run newChange -w packages/toolkit

@jpinkney-aws
Copy link
Contributor

FWIW 4.16.1 (the newest mynah ui version) has just been released so I don't think the beta version is relevant anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants