telemetry(amazonq): Adding cwsprChatProgrammingLanguage parameter to insertAtCursor and CopyAtClipboard events #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retryBuilds |
bweedop
reviewed
Oct 11, 2024
manodnyab
reviewed
Oct 15, 2024
plugins/core/jetbrains-community/resources/telemetryOverride.json
Outdated
Show resolved
Hide resolved
.../software/aws/toolkits/jetbrains/services/cwc/controller/chat/messenger/ChatPromptHandler.kt
Outdated
Show resolved
Hide resolved
manodnyab
reviewed
Oct 16, 2024
| @@ -143,6 +145,24 @@ class ChatPromptHandler(private val telemetryHelper: TelemetryHelper) { | |||
| } | |||
| } | |||
|
|
|||
| private fun extractCodeBlockLanguage(message: String): String { | |||
There was a problem hiding this comment.
Can you please add a test for this?
There was a problem hiding this comment.
Moved extractCodeBlockLanguage to shared/TextUtils file and added test cases.
manodnyab
approved these changes
Oct 16, 2024
plugins/core/core/src/software/aws/toolkits/core/utils/TextUtils.kt
Outdated
Show resolved
Hide resolved
rli
approved these changes
Oct 16, 2024
| fun extractCodeBlockLanguage(message: String): String { | ||
| // This fulfills both the cases of unit test generation(java, python) and general use case(Non java and Non python) languages. | ||
| val defaultTestGenResponseLanguage: String = "plaintext" | ||
| val indexStart: Int = 3 |
There was a problem hiding this comment.
3 is a property of '```', shouldn't we key off of that instead?
| // This fulfills both the cases of unit test generation(java, python) and general use case(Non java and Non python) languages. | ||
| val defaultTestGenResponseLanguage: String = "plaintext" | ||
| val indexStart: Int = 3 | ||
| val codeBlockStart = message.indexOf("```") |
There was a problem hiding this comment.
are there any other edge cases with this we need to worry about?
There was a problem hiding this comment.
- If we use this
extractCodeBlokLanguage, we assume code generated should start or at-least will have 3 backticks with language name. - So If generated code doesn't provide language after ``` we assume the language to be
plaintext - Even for counting number of code blocks, we are implementing this approach for recognizing code blocks with 3 backticks, until backend provide IDE this data.
- Right now this is used only for telemetry purposes
bweedop
approved these changes
Oct 16, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
imykhai
approved these changes
Oct 16, 2024
|
/retryBuilds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
interactWithMessageis missingcwsprChatProgrammingLanguageparameter which helps to understand the language of generated code.cwsprChatProgrammingLanguageparameter for insertAtCursor and CopyAtClipboard events.cwsprChatProgrammingLanguagein commons package: telemetry: Adding cwsprChatProgrammingLanguage aws-toolkit-common#883cwsprChatHasProjectContext and cwsprChatTotalCodeBlocksin in commons package: telemetry: cwsprChatHasProjectContext and cwsprChatTotalCodeBlocks aws-toolkit-common#884Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.