[WIP] Modeled authentication resolvers #3517
Conversation
|
|
||
| // TODO: In the generated version, use a singleton for the scheme resolver (similar to marshallers) to | ||
| // prevent creating a new instance for each request. | ||
| var authResolver = new AutoScalingAuthSchemeResolver(); |
There was a problem hiding this comment.
Since there is one instance of AutoScalingAuthSchemeHandler for the the service client you could make AutoScalingAuthSchemeResolver a member variable instead of a singleton.
| { | ||
| var options = new List<IAuthSchemeOption>(); | ||
|
|
||
| switch (authParameters.Operation) |
There was a problem hiding this comment.
Won't we have to check more then just the operation name for determining the auth? If so then a switch statement might not be a good fit. For example with EventBridge the auth changes if the EndpointId is set. Or is that type of resolution out of scope for the auth resolver.
There was a problem hiding this comment.
Yes, for services such as S3 and EventBridge we'll need to evaluate the auth options from the endpoint-rule-set files (which is why I was planning to address them separately - their resolvers will still be generated, but their logic will be more complex).
This is a follow-up to #3392 as that branch was out-of-date. I want to make sure the feedback is addressed before generating the resolvers for ~400 services.