do not require checksum algorithm when checksum is set #2871
+117
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There is an issue where if you specify a checksum but not the checksum algorithm the functions
ChecksumAlgorithmHasBeenSet
andGetChecksumAlgorithmName
would not return the expected value. This issue especially shows its head when you are using s3express and do something likewe use the logic in
ChecksumAlgorithmHasBeenSet
andGetChecksumAlgorithmName
to determine if we need to default to crc32 as s3express does not support md5.This changes to call
SetChecksumAlgorithm
when setting a checksum so that the implicit requirement of setting the checksum algorithm is no longer required.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.