Avoid processing log statement if logger has been destructed #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
approved these changes
Jan 29, 2024
SergeyRyabinin
force-pushed
the
sr/loggerFix
branch
from
44e798f to
1414a58
Compare
jeking3
suggested changes
Jan 30, 2024
| @@ -63,7 +63,8 @@ namespace Aws | |||
| std::mutex m_logQueueMutex; | |||
| std::condition_variable m_queueSignal; | |||
| Aws::Vector<Aws::String> m_queuedLogMessages; | |||
| bool m_stopLogging; | |||
| bool m_stopLogging = false; | |||
There was a problem hiding this comment.
This is redundant to the constructor at line 61.
| @@ -63,7 +63,8 @@ namespace Aws | |||
| std::mutex m_logQueueMutex; | |||
| std::condition_variable m_queueSignal; | |||
| Aws::Vector<Aws::String> m_queuedLogMessages; | |||
| bool m_stopLogging; | |||
| bool m_stopLogging = false; | |||
| bool m_loggingThreadStopped = false; | |||
There was a problem hiding this comment.
Should this be initialized in the constructor instead?
| // explicitly wait for logging thread to finish | ||
| { | ||
| std::unique_lock<std::mutex> locker(m_syncData.m_logQueueMutex); | ||
| if (!m_syncData.m_loggingThreadStopped) |
There was a problem hiding this comment.
Should this be "while" instead of "if" and not use a conditional wait_for? It is not safe to leave the destructor until we know the thread is gone.
There was a problem hiding this comment.
there is .join for the thread later.
I just did not want to block user code if the boolean is never set.
SergeyRyabinin
force-pushed
the
sr/loggerFix
branch
from
1414a58 to
7870772
Compare
sbiscigl
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the middle of logging
Issue #, if available:
in case of heavy mis-use of basic-use such as in
the logger may perform
on already destructed self.
With custom memory management enabled, it will result in UB.
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.