Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync FindCrypto. Add option to force crypto linkage #2829

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Jan 26, 2024

Description of changes:

Syncs FindCrypto from S2N, and adds option to force usage of static or dynamic crypto.

The reason these options are being introduced is to force the SDK to use a static or dynamic libcrypto independent of BUILD_SHARED_LIBARIES. Currently if BUILD_SHARED_LIBARIES is set to OFF there is no way to force the SDK to use a dynamic libcrypto.

running with something like

cmake -DBUILD_ONLY="s3" \
  -DBUILD_SHARED_LIBS=OFF

will result in static crypto being chosen over dynamic if dynamic is present

cmake -DBUILD_ONLY="s3" \
  -DBUILD_SHARED_LIBS=OFF \
  -DAWS_USE_CRYPTO_SHARED_LIBS=ON \
  -DS2N_USE_CRYPTO_SHARED_LIBS=ON

will result on dynamic crypto being used even though we are building statically

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl force-pushed the force-crypto-cmake branch 2 times, most recently from 65a2373 to 68ab08b Compare February 14, 2024 19:56
@sbiscigl sbiscigl marked this pull request as ready for review February 15, 2024 01:03
@sbiscigl sbiscigl merged commit f49a629 into main Feb 15, 2024
4 checks passed
@sbiscigl sbiscigl deleted the force-crypto-cmake branch February 15, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants