Fix Transcribe streaming "A complete signal was sent without ending frame" #2827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is merged and released in the SDK v 1.11.279
Issue #, if available:
Description of changes:
Encode very empty frame (=no payload section) http2 frame instead of a frame with headers as a payload.
According to the transcribe documentation and an original SDK implementation, the final "empty frame" should be constructed like a regular data frame, i.e.
while Transcribe server expects absolutely no payload for a final empty event (in the payload section of the h2 frame), only headers section must be present (and of course h2 prelude, markers and crc32 like for any other regular h2 frame), i.e.
This does not fix performance issues of HTTP2 streaming within the SDK, except increasing the default buffer size for sent/received events.
I'll submit another PR later for performance issues.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.