Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail build on newer MSVS on GTEST_SKIP macro #2819

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

SergeyRyabinin
Copy link
Contributor

Issue #, if available:

...\aws-cpp-sdk-core-tests\utils\threading\ReaderWriterLockTest.cpp(94): error C2220: the following warning is treated as an erro
r [...\aws-sdk-cpp\build\tests\aws-cpp-sdk-core-tests\aws-cpp-sdk-core-tests.vcxproj]
...\aws-sdk-cpp\tests\aws-cpp-sdk-core-tests\utils\threading\ReaderWriterLockTest.cpp(94): warning C4702: unreachable code [...\aws-sdk
-cpp\build\tests\aws-cpp-sdk-core-tests\aws-cpp-sdk-core-tests.vcxproj]

Description of changes:
pragma ignore warning in AwsGTestSuite header (should be used only in tests).
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin merged commit e385111 into main Jan 23, 2024
3 of 4 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/winGTestSkip branch January 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants