fix s3 copy constructor #2798
Merged
fix s3 copy constructor #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
commented
Dec 21, 2023
| #include <aws/core/auth/AWSCredentialsProviderChain.h> | ||
|
|
||
| std::shared_ptr<AWSCredentialsProvider> AWSAuthSignerProvider::GetCredentialsProvider() const { | ||
| return MakeShared<DefaultAWSCredentialsProviderChain>("AWSAuthSignerProvider"); |
There was a problem hiding this comment.
In a perfect world i would want to make the function pure virutal, but for backwards compat we can return the default credential provider.
SergeyRyabinin
approved these changes
Dec 21, 2023
DmitriyMusatkin
approved these changes
Dec 21, 2023
sbiscigl
force-pushed
the
s3-copy-ctor
branch
from
87fe9fb to
edc0b22
Compare
sbiscigl
force-pushed
the
s3-copy-ctor
branch
from
edc0b22 to
f2d85ab
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There is currently a bug where if you copy construct a S3Client it will use the default credential provider chain instead of a specified credential change. This changes the copy ctor to re-create the signers with previously provided credential provider.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.