Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crt proxy #2777

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Crt proxy #2777

merged 2 commits into from
Dec 4, 2023

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Dec 4, 2023

Description of changes:

Based on and cherry picked from pull/2693. I just added code generation to it. from the original PR:

Pass proxy settings from S3CrtConfig through to the aws_s3_client_config struct for CRT

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl changed the title Crt proxy pr Crt proxy Dec 4, 2023
@sbiscigl sbiscigl marked this pull request as ready for review December 4, 2023 20:49
@sbiscigl sbiscigl merged commit d8dfdf5 into main Dec 4, 2023
3 of 4 checks passed
@sbiscigl sbiscigl deleted the crt-proxy-pr branch December 4, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants