Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix namespace collision detection on member varibles #2739

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Nov 8, 2023

Description of changes:

Fixes a issue with namespace collsion detection in codegen. Regretfully though it would appear one api that did not need to be renamed fell in this logic and backwards compat had to be built in. All ongoing namespace collisions will be fixed though.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* only to capture these old APIs. This list should never be added to
* under any circumstances and only exists to preserve backwards compat.
*/
private static List<String> LEGACY_RENAMED_APIS = ImmutableList.of(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im unhappy about this, but backwards compat is backwards compat :(

@sbiscigl sbiscigl force-pushed the fix-codegen-collision branch from 36f9216 to cad65b2 Compare November 9, 2023 14:26
@sbiscigl sbiscigl marked this pull request as ready for review November 9, 2023 16:28
@sbiscigl sbiscigl merged commit 69a1790 into main Nov 9, 2023
3 checks passed
@sbiscigl sbiscigl deleted the fix-codegen-collision branch November 9, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants