Handle the case when endpoints rules can return more than one AuthScheme #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
force-pushed
the
sr/epMultiAuth
branch
2 times, most recently
from
198c30e to
8a4ccbc
Compare
sbiscigl
approved these changes
Nov 7, 2023
| onPreviousLinesLength = builder.length(); | ||
| separator = ",\n" + String.join("", Collections.nCopies(indent + 1, " "));; | ||
| if (isEndpointProperty) | ||
| separator = ",\n" + String.join("", Collections.nCopies(indent + 3, " ")); |
There was a problem hiding this comment.
something to explore for later: doing all those indent calculations is so messy. can we generate badly formatted code and just run it through formatter?
There was a problem hiding this comment.
frankly speaking I though about just dumping a json and then parsing it in runtime.
But for now just diving deeper into a rabbit hole.
DmitriyMusatkin
approved these changes
Nov 7, 2023
…heme by selecting the first/highest priority one
SergeyRyabinin
force-pushed
the
sr/epMultiAuth
branch
from
8a4ccbc to
a2d12d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by selecting the first/highest priority one
Issue #, if available:
n/a
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.