Use regular URI Query Path encoding according to RFC 3986 by default #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
force-pushed
the
sr/urlEncodeChars
branch
2 times, most recently
from
aa88365 to
6b99951
Compare
sbiscigl
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Just two high level questions before we ship it.
Should we make this the new deafult or opt-in to prevent any unwanted behavior?
Although the api for url encode can be set for legacy behavior, should we surface it through client configuration for easier use of turning it on/off?
SergeyRyabinin
force-pushed
the
sr/urlEncodeChars
branch
from
6b99951 to
0545f80
Compare
SergeyRyabinin
force-pushed
the
sr/urlEncodeChars
branch
from
0545f80 to
08cfb35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
Use regular URI Query Path encoding according to RFC 3986 by default
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.