Add Windows version checking before setting proxy flag #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurugubs
reviewed
Oct 9, 2023
src/aws-cpp-sdk-core/source/http/windows/WinHttpSyncHttpClient.cpp
Outdated
Show resolved
Hide resolved
SergeyRyabinin
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The access type passed when opening a WinHTTP-session is set to
WINHTTP_ACCESS_TYPE_AUTOMATIC_PROXYif the application using aws cpp sdk is built with >= Windows 8,1 SDK and haveallowSystemProxyset to True. As a result, when running the application on Windows version older than 8.1, the WinHTTP-session cannot be successfully initiated. This change adds runtime version checking to determine the proper parameter to use.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.