Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute enum hashes at compile time #2701

Closed
wants to merge 2 commits into from
Closed

Conversation

SergeyRyabinin
Copy link
Contributor

Issue #, if available:
HashString is called 254 times when S3 shared object is loaded at the static init stage
Description of changes:
Use constexpr to calculate this values at the build time.
HashString will be called only 28 times when loading a core+s3 libs.
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin force-pushed the sr/HashCompileTime branch 4 times, most recently from b78c30c to e9fcc28 Compare October 12, 2023 22:30
@jmklix jmklix closed this Mar 8, 2024
@jmklix jmklix deleted the sr/HashCompileTime branch March 8, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants