-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): trace output (-vv) is useless when files are uploaded #33104
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33104 +/- ##
==========================================
+ Coverage 81.53% 81.54% +0.01%
==========================================
Files 226 227 +1
Lines 13769 13793 +24
Branches 2414 2419 +5
==========================================
+ Hits 11227 11248 +21
- Misses 2270 2272 +2
- Partials 272 273 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Reason for this change
When running the CDK CLI in trace mode (with
-vv
), e.g.cdk deploy -vv
we log all SDK calls and their inputs. For file uploads, the input contains the buffer of the file to be uploaded. This results in really bad output:Now in this case we are only uploading 138 bytes. Imagine what this log looks like for files of 10MiB or 100MiB. Reportedly this also crashed every terminal.
Description of changes
There's no need to log the buffer bytes. Instead replace it with a string indicating its a buffer and the buffer length:
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license