Support Active Directory if joined on non-cross account #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OwnerDirectoryDescription` does not seem to exist on Centos 7.9 ```aws ds describe-directories --region us-east-1 --query "DirectoryDescriptions[?DirectoryId =='d-90676a899f'].OwnerDirectoryDescription.DirectoryId | [0]" | sed 's/"//g'``` Results in: null (incorrect) ```aws ds describe-directories --region us-east-1 --query "DirectoryDescriptions[?DirectoryId =='d-90676a899f'].DirectoryId | [0]" | sed 's/"//g'``` Results in: d-* (correct)
|
It appears this happens because the script assumes the Active Directory is shared. |
|
Added some logic, maybe messy and could use a touchup. Will look for root directory ID first, then override if share exists. |
icarusmiles
changed the title
smhmhmd
reviewed
Jan 4, 2022
@smhmhmd It only exists if shared. So what about when the directory isn't shared? The docs don't indicate that this will only work on shared directories. This script is broken if the directory is not shared. If |
|
Thanks, I will help @VishnuKarthikRavindran check this and take the contribution in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OwnerDirectoryDescriptiondoes not seem to exist in the query results.... running on Centos 7.9Results in: null (incorrect)
--
Results in: d-* (correct)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.