Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for typos #30

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix for typos #30

merged 1 commit into from
Oct 15, 2024

Conversation

andreachild
Copy link
Contributor

Fix for typos mostly in documentation but also a couple command line arguments and one model-scoped variable that had 'neptume' instead of 'neptune'.

Copy link
Contributor

@kmcginnes kmcginnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are great. I offered a few additional suggestions.

Also worth considering is that the fix for the typo in the command line argument is technically a breaking change. I assume we are good with that, but I wanted to ask the question.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@andreachild
Copy link
Contributor Author

andreachild commented Oct 12, 2024

Also worth considering is that the fix for the typo in the command line argument is technically a breaking change. I assume we are good with that, but I wanted to ask the question.

I have brought it up before with stakeholders that I intended to fix the command line option spelling and there didn't seem to be concerns (other than to ensure the relevant documentation is also updated) but I will call out it's a breaking change as well and see what the feedback is. It might not have clicked earlier that it's a breaking change if there are any existing scripts that use this utility.

Copy link
Contributor

@kmcginnes kmcginnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

…arguments and one model-scoped variable that had 'neptume' instead of 'neptune'.
@Cole-Greer Cole-Greer merged commit fd0a4fc into aws:main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants