Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix big-buck-bunny and Lombok build issues #193

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefankiesz
Copy link

@stefankiesz stefankiesz commented May 6, 2024

  • There is a bug in this version of Lombok that causes switch-cases to all turn into default cases causing "Duplicate default" compilation errors: [BUG] compilation error : duplicate default label projectlombok/lombok#3087

    • The build is failing for Java 11, 17, and 21.
    • Although we set Lombok dependency version to 1.18.22, the lombok-maven-plugin is still on version 1.18.20. There is no newer version of lombok-maven-plugin.
    • Refactored all of the switch-case statements to be if-else blocks. Now successfully builds on Java 11. It builds successfully on Java 17 only after running mvn clean install twice. Still not supporting Java 21.
      • More investigating to do on Java 17, but this PR should completely resolve the issues for Java 11.
  • There is no file called big-buck-bunny_trailer.webm, but tests are attempting to access it.

    • Removed the test cases that use it.

ToDo:

  • Add back the bunny tests, and add in the missing file.
  • Add to the ReadMe a matrix of tested Java versions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stefankiesz stefankiesz marked this pull request as draft August 28, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant