Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log acs/tacs endpoint for connection issues #4401

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

xxx0624
Copy link
Contributor

@xxx0624 xxx0624 commented Oct 18, 2024

Summary

This PR is used to log acs/tacs endpoint information which would be helpful to debug connection issues between Agent and the dependency, especially for multi tasks on same host.

Implementation details

Testing

New tests cover the changes:

No

Manual test

// Launch a task and we can see when the connection is closed, we are able to see the endpoint we use
Connection closed for a valid reason: websocket: close 1000 (normal): ConnectionExpired: Reconnect to continue

Description for the changelog

Enhancement - log acs/tacs endpoint

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?

No

Does this PR include the addition of new environment variables in the README?

No

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xxx0624 xxx0624 marked this pull request as ready for review October 21, 2024 17:26
@xxx0624 xxx0624 requested a review from a team as a code owner October 21, 2024 17:26
@xxx0624 xxx0624 changed the title Log acs endpoint for connection issues Log acs/tacs endpoint for connection issues Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants