Fix require_confirmation_dag_change (apache#42063) (apache#42211)

* Add 'lower' to require_confirmation_dag_change * Set input attribute only if require-confirmation is true (cherry picked from commit 9a1f9e9) Co-authored-by: Nikita <[email protected]>
aws-mwaa · Sep 13, 2024 · 2a76973 · 2a76973
1 parent 0b4bd74
commit 2a76973
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/airflow/www/static/js/dag.js b/airflow/www/static/js/dag.js
@@ -55,7 +55,7 @@ $("#pause_resume").on("change", function onChange() {
   const $input = $(this);
   const id = $input.data("dag-id");
   const isPaused = $input.is(":checked");
-  const requireConfirmation = $input.data("require-confirmation");
+  const requireConfirmation = $input.is("[data-require-confirmation]");
   if (requireConfirmation) {
     const confirmation = window.confirm(
       `Are you sure you want to ${isPaused ? "resume" : "pause"} this DAG?`

diff --git a/airflow/www/templates/airflow/dag.html b/airflow/www/templates/airflow/dag.html
@@ -129,7 +129,7 @@ <h3>
           {% endif %}
           <label class="switch-label{{' disabled' if not can_edit_dag else ''  }} js-tooltip" title="{{ switch_tooltip }}">
             <input class="switch-input" id="pause_resume" data-dag-id="{{ dag.dag_id }}"
-                   data-require-confirmation="{{ appbuilder.require_confirmation_dag_change }}"
+                   {{ "data-require-confirmation" if appbuilder.require_confirmation_dag_change else "" }}
                    type="checkbox"{{ " checked" if not dag_is_paused else "" }}
                    {{ " disabled" if not can_edit_dag else "" }}>
             <span class="switch" aria-hidden="true"></span>