Skip to content

Commit

Permalink
Remove dependency on special tests for tests finalization (apache#40264)
Browse files Browse the repository at this point in the history
Tests finalization is run generally when all tests succeded in
canary run. What the finalization does is:

* updating constrainst
* pushing them
* updating image cache
* summarizing warnings

However special tests are really to test some special cases - back
compatibility, lowest dependencies, latest boto etc. All those tests
will only be run in a few selected PRs where we upgrade dependencies
and they will not affect "regular" PRs, so we can safely update
the constraints and update the cache without waiting for special tests.

This will increase the frequency of updates to constraints - because
now they might be quite delayed in case some special tests fail, but
this is unnecessary holding the constraints update.
  • Loading branch information
potiuk authored Jun 15, 2024
1 parent 161fd55 commit 1d7ede7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,6 @@ jobs:
- tests-postgres
- tests-non-db
- tests-integration
- tests-special
uses: ./.github/workflows/finalize-tests.yml
with:
runs-on-as-json-public: ${{ needs.build-info.outputs.runs-on-as-json-public }}
Expand Down

0 comments on commit 1d7ede7

Please sign in to comment.