docs: Remove "Node Groups" section and mention terraform-aws-modules
#1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of v5 migration, aws-ia#1428 removes "Node Groups" page, but forgot to remove the page button. This commit removes the "Node Groups" button in the documentation page.
As part of v5 migration, aws-ia#1428 removes "Node Groups" page. As a result, new users likely lost what to do when configuring a cluster. We at least need to mention that we use `terraform-aws-modules/eks/aws` to avoid confusion.
kbumsik
temporarily deployed
to
EKS Blueprints Test
GitHub Actions
Inactive
bryantbiggs
changed the title
terraform-aws-modulesterraform-aws-modules
bryantbiggs
approved these changes
Feb 27, 2023
gminiba
pushed a commit
to gminiba/terraform-aws-eks-blueprints
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As part of v5 migration, #1428 removes "Node Groups" page, but forgot to remove the page button.
This PR removes the "Node Groups" button in the documentation page.
Also, new users likely lost what to do when configuring a cluster.
We at least need to mention that we use
terraform-aws-modules/eks/awsto avoid confusion.More
pre-commit run -awith this PRFor Moderators
Additional Notes