Update schema diff to match schema format for customer set values #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
SGR evaluates backward compatibility on readOnlyProperties - only new properties can be added to readOnly
SGR incorrectly fails on new properties being added to readOnly.
Example failure:
SGR rules are not be able to handle the mapping from
/properties/Workgroup/MaxCapacity
to/properties/Workgroup/properties/MaxCapacity
. This causes schema check failure when changes are allowed.The above schema will cause this rule to fail:
Description of changes:
Change is only one line:
This is placed within the
_cast_path
method which is called on every path found within theDeepDiff
to process them from form:root['properties']['Workgroup']['properties']['MaxCapacity']
->properties/Workgroup/properties/MaxCapacity
By replacing all occurrences of
]['properties'][
with][
we shrink the input and remove all nested properties within the path returned by the 'DeepDiff' operation.Unit tests updated to correct expected path output for schema evaluation.
Testing done locally though integration / unit tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.