Merge pull request #5 from awendt/fix-notifications-for-reassigned-prs

fix: reducer.notificationsForReassignedPRs checks for null
awendt · Nov 9, 2024 · 24d3d19 · 24d3d19
2 parents 27692c0 + 63f6e53
commit 24d3d19
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/lib/notification-reducer.js b/lib/notification-reducer.js
@@ -21,7 +21,7 @@ export class NotificationReducer {
 
   get notificationsForReassignedPRs() {
     return this.notificationsWithPullRequests.filter((notification) => {
-      return notification.reason === "subscribed" && notification.pull_request.assignee != this.me && notification.pull_request.assignee != ""
+      return notification.reason === "subscribed" && notification.pull_request.assignee != this.me && notification.pull_request.assignee !== null
     });
   }
 

diff --git a/test/fixtures/pr21.json b/test/fixtures/pr21.json
@@ -4,6 +4,7 @@
   "number": 21,
   "state": "closed",
   "title": "Add support for resource-specific tags",
+  "assignee": null,
   "user": {
     "login": "jansiwy",
     "id": 610800,

diff --git a/test/fixtures/pr45.json b/test/fixtures/pr45.json
@@ -4,6 +4,7 @@
   "number": 45,
   "state": "open",
   "title": "Breaking change: Unify support for resource-specific tags",
+  "assignee": "jansiwy",
   "user": {
     "login": "jansiwy",
     "id": 610800,

diff --git a/test/reducer.js b/test/reducer.js
@@ -46,6 +46,7 @@ describe('Reducer', async () => {
       'number',
       'state',
       'title',
+      'assignee',
       'user',
       'body',
       'created_at',