Fix issue when refreshing a page #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When refreshing a page in Firefox (not a hard refresh) the input value stayed the same. The issue was fastLiveFilter outputted the same as for an empty input. The callback function was called but the result list was unchanged / unfiltered The fix here removes the callback(len); line and adds a triggerHandler to fully initialise. This worked for me. When the page is refreshed, it checks the current value of the input and does its thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Anthony
This is my first pull request so I hope I'm doing this right.
Recently I used fastLiveFilter in a project I'm working on and discovered an issue. When refreshing the page, in Firefox at least (not a hard refresh), the input value stayed the same. The issue was that fastLiveFilter outputted the same as for an empty input. The callback function was called but the resulting list was unchanged / unfiltered.
The fix here removes the callback(len); line and adds a triggerHandler to initialise. It worked for me. When the page was refreshed fastLiveFilter checked the current value of the input and did its fab thing.
all the best
Dave