Suspend execution of tasks #6090
Draft
+337
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtja
force-pushed
the
runners_refactor
branch
from
7d74d59 to
52ef928
Compare
This is a refactoring of runners, which runs python scripts. It moves most of the code related to running and monitoring processes into base classes. This change removes duplicities across the runners, and it will help with implementation of common features like signal handling. Signed-off-by: Jan Richter <[email protected]>
This is a removal of legacy code for signal handling. This signal handling was useful for the legacy runner where all tasks were running in child processes. But now when we use spawners for creating tasks each with different implementation, we need to handle the signal handling in the spawners itself. Signed-off-by: Jan Richter <[email protected]>
richtja
force-pushed
the
runners_refactor
branch
from
52ef928 to
5101e9a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6090 +/- ##
==========================================
- Coverage 68.66% 68.61% -0.05%
==========================================
Files 203 203
Lines 21970 21964 -6
==========================================
- Hits 15085 15071 -14
- Misses 6885 6893 +8 ☔ View full report in Codecov by Sentry. |
richtja
force-pushed
the
runners_refactor
branch
2 times, most recently
from
31fa2ca to
aeb256a
Compare
This change will spawn the new subprocess task into its own process group. It will give us more control over the signal handling since the signals won't be propagated to the subprocess any more. Signed-off-by: Jan Richter <[email protected]>
This commit introduces the suspend execution feature to the nrunner. The suspend execution was available on the legacy runner, but we didn't move it to the nrunner. With this feature, it is possible to pause execution of python based task on process spawner by sending SIGTSTP signal (ctrl+z). It is helpful for debugging test execution. Reference: avocado-framework#6059 Signed-off-by: Jan Richter <[email protected]>
richtja
force-pushed
the
runners_refactor
branch
from
aeb256a to
852a64e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the suspend execution feature to the nrunner. The
suspend execution was available on the legacy runner, but we didn't move
it to the nrunner. With this feature, it is possible to pause execution
of python based task on process spawner by sending SIGTSTP signal
(ctrl+z). It is helpful for debugging test execution.
Reference: #6059
Signed-off-by: Jan Richter [email protected]