-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm_xml: set_vm_vcpus() support clusters #4006
vm_xml: set_vm_vcpus() support clusters #4006
Conversation
240b3e3
to
267de2d
Compare
Tested implementation on max_vcpus_topology.py (passing tests shown in mentioned PR), topology.py, and virsh_guestvcpus.py. Passing topology.py test: [root@beaver-6 /]# /usr/local/bin/avocado run --vt-type libvirt --vt-machine-type q35 topology.positive.hotplug --vt-connect-uri qemu:///system Passing virsh_guestvcpus.py tests: [root@beaver-6 /]# /usr/local/bin/avocado run --vt-type libvirt --vt-machine-type q35 virsh.guestvcpus.normal_test --vt-connect-uri qemu:///system |
@rh-jugraham Plz fix the error in signedoff-check, thx! |
0c511cc
to
e377734
Compare
Updated the commit message! |
There is one more failure in static check, plz resolve it, thx! |
Signed-off-by: Julia Graham <[email protected]>
e377734
to
ee0bbfb
Compare
Updated! I don't have the permissions to rerun the workflow but I fixed the issue I saw |
Signed-off-by: Julia Graham [email protected]
Modified set_vm_vcpus() to support clusters.