Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add identitystore group and user data source dependency null resources #17

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

aurimasmick
Copy link
Contributor

@aurimasmick aurimasmick commented Oct 2, 2023

Description

Add null resources which will trigger identitystore group and user data source refresh. This allows to create SSO users and groups in the same state file as terraform-aws-sso module resources and without adding depends_on argument at the module level. (check with_dependencies example). When using null resource instead of depends_on, it will only recreate account assignments, when aa new SSO group is added. It will NOT re-create all module resources, after a new AWS Account is added.

Breaking Changes

When updating the module version, it will re-create all account assignments on the first terraform apply as it creates null_resources, so can disconnect the sessions and require re-authentication.

Testing

Tested manually.

@github-actions github-actions bot added the enhancement New feature or request label Oct 2, 2023
@aurimasmick aurimasmick merged commit 9f25d90 into main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant