consistent grenade/missile/plasma shooting rates #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
many frame number checks were of the form
if (doSomething < frameNumber) {
doSomething = FrameFromNow(3)
}
For classic mode that means to doSomething at most every 4th frame. But for high-FPS, this code would start
doing something on frame 13 instead of on frame 16... faster than classic.
Changing code to work across frame rates like this:
if (doSomething <= frameNumber) {
doSomething = FrameFromNow(3+1)
}
The HECTOR.Boost* tests had to be fixed because they were actually boosting on frame 1 since boostEndFrame inits to 0.
so that all frame rates behave the same on shooting rate
assertivist
pushed a commit
that referenced
this pull request
Aug 13, 2024
* fix FramesFromNow usage
many frame number checks were of the form
if (doSomething < frameNumber) {
doSomething = FrameFromNow(3)
}
For classic mode that means to doSomething at most every 4th frame. But for high-FPS, this code would start
doing something on frame 13 instead of on frame 16... faster than classic.
Changing code to work across frame rates like this:
if (doSomething <= frameNumber) {
doSomething = FrameFromNow(3+1)
}
* fix tests and bugs found by tests
The HECTOR.Boost* tests had to be fixed because they were actually boosting on frame 1 since boostEndFrame inits to 0.
* added 1 classic-frame limiter to the plasma shot
so that all frame rates behave the same on shooting rate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that all weapon reload times are the same across different frame rates. They were slightly faster for higher frame rates due to the comparisons of the form:
That were changed like this:
Also added a 1-classic-frame limiter to plasma shots which means they can only happen every 64ms (most humans can't click that fast).
Bonus fix, boosting also had this problem too so you'll get back 48ms of boosting in high-FPS games. I need all the boosting I can get!