more frag fixes #412
Merged
more frag fixes #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crux of abort/frag problems is/was that the notification of the abort was asynchronous. But the other players in the game don't need to get the async message because they will get the abort key press so stop sending that message to active players. Also, there's no good reason to keep updating the frag checksum for players who are out of the game. This was also related to the previous problem where players were adding in the location checksum and stopping that addition at different times. This fix is really extra insurance that an aborted or dead player won't cause frags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crux of abort/frag problems is/was that the notification of the abort was asynchronous. But the other players in the game don't need to get the async message because they will get the abort key press so stop sending that message to active players.
Also, there's no good reason to keep updating the frag checksum for players who are out of the game. This was also related to the previous problem where players were adding in the location checksum and stopping that addition at different times. This fix is really extra insurance that an aborted or dead player won't cause frags.