Skip to content

Commit

Permalink
don't pass in defaultRegisterer from the app_request_network
Browse files Browse the repository at this point in the history
  • Loading branch information
iansuvak committed Aug 27, 2024
1 parent 2153f1a commit e047507
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion peers/app_request_network.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func NewNetwork(
}

// Create the handler for handling inbound app responses
handler, err := NewRelayerExternalHandler(logger, metrics, prometheus.DefaultRegisterer)
handler, err := NewRelayerExternalHandler(logger, metrics)
if err != nil {
logger.Error(
"Failed to create p2p network handler",
Expand Down
3 changes: 1 addition & 2 deletions peers/external_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ type expectedResponses struct {
func NewRelayerExternalHandler(
logger logging.Logger,
metrics *AppRequestNetworkMetrics,
registerer prometheus.Registerer,
) (*RelayerExternalHandler, error) {
// TODO: Leaving this static for now, but we may want to have this as a config option
cfg := timer.AdaptiveTimeoutConfig{
Expand All @@ -54,7 +53,7 @@ func NewRelayerExternalHandler(
TimeoutHalflife: constants.DefaultNetworkTimeoutHalflife,
}

timeoutManager, err := timer.NewAdaptiveTimeoutManager(&cfg, registerer)
timeoutManager, err := timer.NewAdaptiveTimeoutManager(&cfg, prometheus.DefaultRegisterer)
if err != nil {
logger.Error(
"Failed to create timeout manager",
Expand Down

0 comments on commit e047507

Please sign in to comment.