Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

what does mean mult = (points_num - 1.0) / points_num in line 408 in the VoxelGrid.cu of ndt_gpu? #71

Open
nonlinear1 opened this issue Jun 22, 2022 · 3 comments

Comments

@nonlinear1
Copy link

I am studying the ndt_gpu of autoware_ai_perception. I found a mult is multiplied to the covariace matrix in line 408 in VoxelGrid.cu of ndt_gpu. the snip of sources code which includes the mult is from line 408 to line 411 is as follow:

double mult = (points_num - 1.0) / points_num;

cov(0, 0) = ((cov(0, 0) - 2.0 * p0 * c0) / points_num + c0 * c0) * mult;
cov(0, 1) = ((cov(0, 1) - 2.0 * p0 * c1) / points_num + c0 * c1) * mult;

Could someone know this mult means?
Thank you very much!

@YamatoAndo
Copy link
Contributor

@anhnv3991 Could you please answer this question?

@anhnv3991
Copy link

@nonlinear1 I implemented this CUDA code based on the very old version of PCL 1.7, so this must be a bug then. It should be points_num / (points_num - 1.0).
Thanks for reporting.

@nonlinear1
Copy link
Author

Thank you very much!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants