Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

Bug: Publish the wrong map message. #39

Open
ghost opened this issue Oct 31, 2020 · 2 comments · May be fixed by #43
Open

Bug: Publish the wrong map message. #39

ghost opened this issue Oct 31, 2020 · 2 comments · May be fixed by #43
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Oct 31, 2020

Bug report

Hi! Thanks for your excellent work!

I don't understand why the map at last frame was published? Is it better to publish current map (map) instead of previous map (*map_ptr)? If so, the code at line 788 of ndt_mapping.cpp may be changed to
pcl::toROSMsg(map, *map_msg_ptr);
Or maybe I misunderstand something. :)
@ghost ghost added the bug Something isn't working label Oct 31, 2020
@JWhitleyWork
Copy link

@ShifanZhu Would you be willing to create a Pull Request to resolve the issue?

@ghost
Copy link
Author

ghost commented Dec 25, 2020

Sorry for the late reply. I have fixed the bugs and created a Pull Request. The link is here.

@JWhitleyWork JWhitleyWork linked a pull request Jan 5, 2021 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the bug of publishing incorrect map data
1 participant
@JWhitleyWork