-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce autoware-nightly.repos
#5440
Conversation
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
I thought we were going to do it the way ROS 2 does. https://github.com/ros2/ros2/blob/rolling/ros2.repos High traffic repos pointing to the branches, low traffic pointing to the tags. |
Here is my relevant comment: For these reasons, I am against to maintaining 2 Especially the nightly version is pointing to main or a fast branch for most of the things, it is way too volatile. We don't need to do that. We can just keep maintaining a single The |
@xmfcx Thanks for the comment. Sorry, I forgot about the commen that you made in the discussion. However, I also think we should at least consider make the default branch of Autoware to be stable.
Therefore, I'm starting to think that we should have a stable branch that is maintained daily. Maybe we can raise this as a discussion topic in the next Software WG. |
I understand. I agree that the default branch should always be functioning.
We should update the instructions on the documentation to fix this.
Neither of the main installation methods mention the tags, that's why.
This might be unavoidable for older tags but for the most recent version tag, we can add a CI that runs daily to build and test it. |
That's also possible. I thought having a stable branch or repos file would make us easier to maintain the documentation because then we don't have to update the page every time we release a new tag. |
For that, we can make releases monthly in https://github.com/autowarefoundation/autoware/releases and point to releases page. No need to keep updating the documentation for each new release. Or for the current state, we can point them to use the latest tag from https://github.com/autowarefoundation/autoware/tags This is how we did it with AWSIM Labs https://github.com/autowarefoundation/AWSIM-Labs/releases |
Option 1:
Option 2:
(I will update this comment) |
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@xmfcx @mitsudome-r Thank you for your suggestions. I minimized the repositories in |
Signed-off-by: Yutaka Kondo <[email protected]>
https://github.com/autowarefoundation/autoware/actions/runs/11908366324/job/33183658104?pr=5440 has failed, not sure why though.
|
The syntax is no problem. I ran the workflow again...
|
Signed-off-by: Yutaka Kondo <[email protected]>
It was failed... |
This reverts commit 65e89d1.
Signed-off-by: Yutaka Kondo <[email protected]>
Co-authored-by: M. Fatih Cırıt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR introduces
autoware-nightly.repos
, which changes theversion
value tomain
for the repositories inautoware.repos
. This is provided for those who want to try the latest builds, as version control forautoware.universe
andautoware_launch
has started with #5435.It also adds a
health-check-nightly
workflow, which is the version of thehealth-check workflow
targetingautoware-nightly.repos
.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.