libvirt-mem: Enable check for test_qemu_cmd #5911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following testcases are failing because because of the check for test_qemu_cmd is not added in the script 1. type_specific.io-github-autotest-libvirt.libvirt_mem. positive_test.align_256m.cold_plug: FAIL: Qemu command check fail. (205.37 s) 2. type_specific.io-github-autotest-libvirt.libvirt_mem. positive_test.align_256m.hot_plug: FAIL: Qemu command check fail. (209.51 s) In the libvirt_mem.cfg, the following parameter is set to no - "test_qemu_cmd = no" Hence, the check must be added in all places Signed-off-by: Misbah Anjum N <[email protected]>
After Patch |
sacsant
reviewed
Sep 23, 2024
| @@ -515,7 +515,8 @@ def modify_domain_xml(): | |||
| elif discard: | |||
| vm.start() | |||
| session = vm.wait_for_login() | |||
| check_qemu_cmd(max_mem_rt, tg_size) | |||
| if test_qemu_cmd: | |||
There was a problem hiding this comment.
Seems logical. LGTM.
Additionally have you tested the behaviour with test_qemu_cmd = yes
There was a problem hiding this comment.
Thank you @sacsant
I have tested the behaviour with the "test_qemu_cmd = yes"
The test case fails with "QEMU command check failed" due to the changes with the qemu cmd.
Here is a patch where "test_qemu_cmd" is set to "no" for multiple test cases due to the same reason: https://github.com/autotest/tp-libvirt/pull/3508/files
Looking into it in order to update the test script libvirt_mem.py to match the string search with the updated qemu cmd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libvirt-mem: Enable check for test_qemu_cmd
The following testcases are failing because because of the check for test_qemu_cmd is not added in the script
FAIL: Qemu command check fail. (205.37 s)
FAIL: Qemu command check fail. (209.51 s)
In the libvirt_mem.cfg, the following parameter is set to no - "test_qemu_cmd = no"
Hence, the check must be added in all places
Signed-off-by: Misbah Anjum N [email protected]