Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Docker-related stuff in docker directory #3174

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Oct 26, 2024

Mostly for aesthetic purposes, now instead of 5 files in the root of the repo we will have a single directory.

Due to naming conventions the only way to move .dockerignore to subdirectory without messing with context is to create more files, so I created symlinks to a canonical file in order to avoid code duplication.

Code contributor checklist:

Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@nazar-pc nazar-pc added this pull request to the merge queue Oct 27, 2024
Merged via the queue into main with commit 73a3e50 Oct 27, 2024
12 of 17 checks passed
@nazar-pc nazar-pc deleted the consolidate-docker branch October 27, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants