Async wrapper for sector write in plotting #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that was modified is running in a dedicated thread and wasn't causing any issues for local plotting, but with farming cluster remote plotter expects messages to be received and written to down within certain time limit. By doing synchronous writes in the same thread where other sectors are processed effectively serializes all writes interspersed with other operations. This can result in various timeouts and generally reduces performance.
Wrapping blocking writes into blocking tasks addresses this issue and allows all plotting tasks to make progress concurrently.
Code contributor checklist: