Lock farm early in case it already exists to prevent potential damage of the JSON file #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the JSON file
| ); | ||
|
|
||
| single_disk_farm_info.store_to(directory)?; | ||
| single_disk_farm_info.store_to(directory)?; |
There was a problem hiding this comment.
It seems that we write first and then secure a lock. Am I missing something?
There was a problem hiding this comment.
There is no file to lock yet in case we've just created new farm
There was a problem hiding this comment.
I see. We can create a lock on the directory first (possibly creating it as well) - I believe fs4 treats a directory as a file. However, I don't think it will matter in practice because we protect manual runs which don't expect to have race conditions.
shamil-gadelshin
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One farmer specified the same path twice with different sizes and that caused race condition during farm instantiation that corrupted JSON farm info. We can actually take a lock sooner and that way we wouldn't end up in this situation.
I decided to not invent anything fancy for the case of new farm creation since the risk and potential damage there is low.
Review with whitespace changes ignored, the diff is trivial.
Code contributor checklist: