Skip to content

Commit

Permalink
Add RPC TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
teor2345 committed Sep 9, 2024
1 parent f73c757 commit b0a12d1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions crates/sc-consensus-subspace-rpc/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,8 @@ where
// To avoid RPC connection failures, limit the number of mappings returned in each response,
// or the number of in-flight responses.
fn subscribe_archived_object_mappings(&self, pending: PendingSubscriptionSink) {
// TODO: deny unsafe subscriptions?

// The genesis segment isn't included in this stream. In other methods we recreate is as the first segment,
// but there aren't any mappings in it, so we don't need to recreate it as part of this subscription.

Expand Down Expand Up @@ -873,6 +875,8 @@ where
pending: PendingSubscriptionSink,
hashes: Vec<Blake3HashHex>,
) {
// TODO: deny unsafe subscriptions?

if hashes.len() > MAX_OBJECT_HASHES_PER_SUBSCRIPTION {
error!(
"Request hash count ({}) exceed the server limit: {} ",
Expand Down
1 change: 1 addition & 0 deletions crates/subspace-archiving/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Collection of modules used for dealing with archived state of Subspace Network.

0 comments on commit b0a12d1

Please sign in to comment.