Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French translations #354

Merged
merged 2 commits into from
Dec 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions res/translations/fr/messages.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,7 @@ configuration_dialog_button_cancel = Annuler
running_title = En cours
running_node_title = {$chain_name} Nœud de la blockchain
running_node_title_tooltip = Cliquez pour ouvrir dans le gestionnaire de fichiers
# TODO: Translate
running_node_connections_tooltip = {$connected_peers}/{$expected_peers} peers connected, click for details about required P2P ports
running_node_connections_tooltip = {$connected_peers}/{$expected_peers} Pairs connectées, cliquez pour plus de détails sur les ports P2P requis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are words Nœud and Pairs capitalized, is that really how it is supposed to be? They are not capitalized in English and many other languages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not at all, but in France (often) when a new window appears (new subject) it is capitalized

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but the sentence starts with numbers in this case or with chain name on running_node_title

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, and I didn’t pay attention to the fact that the code starts with a number or a proper noun. Thank you for pointing that out! I’ll make the necessary adjustment

running_node_free_disk_space_tooltip = Espace disque libre restant : {$size}
running_node_status_connecting = Connexion au réseau, meilleur bloc #{$block_number}
running_node_status_syncing_speed_no_eta = , {NUMBER($blocks_per_second, minimumFractionDigits: 2, maximumFractionDigits: 2)} blocs/s
Expand Down