Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/kol get mentions #83

Merged
merged 17 commits into from
Dec 24, 2024
Merged

Refactor/kol get mentions #83

merged 17 commits into from
Dec 24, 2024

Conversation

Xm0onh
Copy link
Member

@Xm0onh Xm0onh commented Dec 24, 2024

This PR is about moving thread of conversation from responseGenerationNode to mentionNode. Now, the thread is also being used in engagementNode, toneAnalysisNode and "responseGenerationNode. The algorithm of fetching mentioned modified and improved by n` factor.

  • The changes in this PR will effect memory viewer. I'll open a seperate PR for that.
  • It would be great to craft the prompts further to take the thread into account properly.
  • One of the nice thing to have is to summarize a conversation thread and extract the important parts and use them instead of passin the whole thread as a prompt. This change will make agent more efficient when we are dealing with large threads.

@Xm0onh Xm0onh added enhancement New feature or request auto-kol labels Dec 24, 2024
@Xm0onh Xm0onh requested a review from jfrank-summit December 24, 2024 03:45
auto-kol/agent/src/services/agents/nodes/mentionNode.ts Outdated Show resolved Hide resolved
auto-kol/agent/src/services/twitter/api.ts Outdated Show resolved Hide resolved
auto-kol/agent/src/services/twitter/api.ts Outdated Show resolved Hide resolved
auto-kol/agent/src/services/twitter/api.ts Outdated Show resolved Hide resolved
@Xm0onh
Copy link
Member Author

Xm0onh commented Dec 24, 2024

@jfrank-summit I discovered a bug in my getThread implementation. For now, let’s keep the new version as a placeholder. I’ve also added the previous function as the origin function for fetching a conv thread.

Let’s prioritize merging this PR since retrieving the thread has been moved to the start of the workflow. I have a more urgent task to address and will revisit this optimization later.

@Xm0onh Xm0onh requested a review from jfrank-summit December 24, 2024 18:06
@Xm0onh
Copy link
Member Author

Xm0onh commented Dec 24, 2024

@jfrank-summit conflicts are resolved.

Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xm0onh Xm0onh merged commit 3b320a0 into main Dec 24, 2024
1 check passed
@Xm0onh Xm0onh deleted the refactor/kol-getMentions branch January 13, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-kol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants