Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Character Selection UX and Fix Minor Typos #153

Merged
merged 8 commits into from
Jan 18, 2025
Merged

Conversation

Xm0onh
Copy link
Member

@Xm0onh Xm0onh commented Jan 18, 2025

This PR improves the ux for selecting a character in the application.

Additionally, it addresses two minor corrections:

  • Version Fix: Corrected the version field in package.json.
  • Typo Correction: Updated autodrive to auto_drive in the README.

@Xm0onh Xm0onh requested a review from jfrank-summit January 18, 2025 00:27
@Xm0onh Xm0onh changed the title Feat/af char cli Enhance Character Selection UX and Fix Minor Typos Jan 18, 2025
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of simplifying the deployment process but I wonder how much useful this will actually be. How many devs will be are running multiple agents (besides me)? I'm not sure, we should find out. Also, it is still tricky to setup config for multiple agents with our current structure though I am working on it here. Wallet and login info are env variables so need to be changed prior to switching, last memory hashes are saved locally and are lacking character info.

I do think having a CLI to walk through initial config setup could also be very useful.

It would be great to get some feedback from others who have setup and deployed an agent. cc: @marc-aurele-besner @clostao @EmilFattakhov

src/index.ts Show resolved Hide resolved
@Xm0onh Xm0onh requested a review from jfrank-summit January 18, 2025 01:06
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xm0onh Xm0onh merged commit 294bc93 into main Jan 18, 2025
5 checks passed
@Xm0onh Xm0onh deleted the feat/af-char-cli branch January 18, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants