Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref/separate timeline response #116

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

Xm0onh
Copy link
Member

@Xm0onh Xm0onh commented Jan 7, 2025

Following issue #111

@Xm0onh Xm0onh requested a review from jfrank-summit January 7, 2025 02:46
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I was looking for here (not explained well, so my fault) is to be able to separate how many tweets it can potentially respond to and how many inform the trend summary. i.e. it wants to summarize the 50 tweets from its timeline and potentially respond to 10 from its timeline. For now, followingRecents should probably be included as "timeline" to give more control on the amount of tweets pulled until (if) they are able to fix elizaOS/agent-twitter-client#43 on agent-twitter-client. Does this make sense?

@Xm0onh
Copy link
Member Author

Xm0onh commented Jan 7, 2025

I got what you meant on the issue.
There is a new variable state named trendAnalysisTweets. This variable will be used by analyzeTrendNode and constists of 1. timeline and 2. followingRecents.
The tweets that we are going to respond is randomly selected NUM_TIMELINE_TWEETS from pulled our timeline tweets + all of the followingRecents.
I think followingRecents are important to check them all. However, you can still control both them with their vars.
As a concerete example on the previous run: "timelineMessageCount": 20, "trendAnalysisMessageCount": 44.

Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xm0onh Xm0onh merged commit 648ca06 into main Jan 8, 2025
1 check passed
@Xm0onh Xm0onh deleted the ref/separate-timeline-response branch January 8, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants