Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/agent frame mul llm #112

Merged
merged 11 commits into from
Jan 7, 2025
Merged

Feat/agent frame mul llm #112

merged 11 commits into from
Jan 7, 2025

Conversation

Xm0onh
Copy link
Member

@Xm0onh Xm0onh commented Jan 5, 2025

This PR is following the issue #105

Anthropic and open ai work well. However, it is a different story for llama. The problem is: my running model is weak and too small, and the model cannot handle parsing jsons very well.
I started to write a script to optimize the parsing and help the model but it is time consuming.

@Xm0onh Xm0onh requested a review from jfrank-summit January 5, 2025 20:18
@Xm0onh Xm0onh requested a review from jfrank-summit January 6, 2025 00:26
@Xm0onh Xm0onh requested a review from jfrank-summit January 6, 2025 02:25
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit more complicated than I was thinking but should work for now, we can rethink structures and config ease later. I left a few comments on the models.

auto-agents-framework/src/services/llm/types.ts Outdated Show resolved Hide resolved
auto-agents-framework/src/services/llm/types.ts Outdated Show resolved Hide resolved
auto-agents-framework/src/services/llm/types.ts Outdated Show resolved Hide resolved
auto-agents-framework/src/services/llm/types.ts Outdated Show resolved Hide resolved
@Xm0onh
Copy link
Member Author

Xm0onh commented Jan 6, 2025

Yea it is a bit complex, but I tried to make it type-safe and string-free.
Also the models were placeholders if someone wants to use them.

@Xm0onh Xm0onh requested a review from jfrank-summit January 6, 2025 17:42
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Xm0onh Xm0onh merged commit dbffd96 into main Jan 7, 2025
1 check passed
@Xm0onh Xm0onh deleted the feat/agent-frame-mul-llm branch January 7, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants